Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issue #887. Do not create orgs if UUID is passed. Correct error messages. #1007

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

brettp
Copy link
Collaborator

@brettp brettp commented Feb 3, 2023

Closes Issue #887

Summary

No longer incorrectly creates orgs if a UUID parameter is passed. Error messages corrected to specify the type of content being created or updated (org or user).

Important Changes

src/controller/org.controller/org.controller.js

  • Cleaned code for POST endpoint
  • Correctly returning from main function if UUID is sent

Testing

Steps to manually test updated functionality, if possible

  • 1) Try to POST to /org to create a new org with the UUID field set in the JSON body
  • 2) Confirm a 400 error is sent
  • 3) Confirm the error message is Providing UUIDs for org creation or update is not allowed.

@brettp brettp requested a review from jdaigneau5 February 3, 2023 20:00
@jdaigneau5 jdaigneau5 linked an issue Feb 3, 2023 that may be closed by this pull request
@jdaigneau5 jdaigneau5 merged commit d24c2ba into dev Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error message and behavior when creating org with UUID
2 participants